search

Notalib / LYT

m.e17.dk
GNU Lesser General Public License v3.0
10 stars 12 forks source link

URL should always reflect current book and current position in book #477

Closed ybk closed 10 years ago

ybk commented 11 years ago

To reproduce:

  1. When playing a book, change for example the background color
  2. Go back to the player
  3. Press F5 to reload page
  4. Try to play book

This - and other places - should make shure the book-player URL is always correct and possible to update

simmoe commented 11 years ago

Well, this is not really a sprint 3 issue - but well known. The solution is simple however - the URL of the back button from #settings is simply http://m.e17.dk/lyt-1.2.0_008/#book-player - reloading that URL will cause in a "blank" player page. Instead the URL should be the deepling to the relevant place in the currently playing book (the same URL that is shared via bookmarks in #book-index)

kirkby commented 11 years ago

The header of this issue should really be "URL should always reflect current book and current position in book". In principle, it has nothing to do with the fact that settings have been changed. Another solution would be to store current book and position in LocalStorage? I think this issue needs more discussion. Pressing F5 at random will probably ruin the app in many places if it depends on current url for state management.

Just to be sure: Is this 1. priority for this sprint?

oleholstandersen commented 10 years ago

See #574