Notalib / LYT

m.e17.dk
GNU Lesser General Public License v3.0
10 stars 12 forks source link

When i make a spelling mistake while searching for a book, the player suggests correct spelling #482

Closed NajaWulff closed 10 years ago

NajaWulff commented 11 years ago

When a user misspells a word in the search, no suggestions as to how to correct it appears.

Possible solution: Old hack using Google.

simmoe commented 11 years ago

@LDHgithub you made something up.. once.. hacking google suggestions and stuff.. what became of that?

LDHgithub commented 11 years ago

In this solution we ask google for suggestions, when SearchCatalog (Autocomplete) suggestions is less than a given number, defined in google_trigger in config.coffee

We need to now what normal spelling mistakes is for dysleksi people (in Danish) - (if this even exists). I guess that is a job for you @simmoe

And then we need to test this new Autocomplete solution.

mzedeler commented 11 years ago

@simmoe: we've tried using the Google hack, but I am not too happy with the result. It is probably an improvement, but not by much.

I've talked to Stine about a general search sprint where we rework the search engine on E17 and integrate it into LYT, because this issue isn't limited to LYT in the first place.

simmoe commented 11 years ago

Right.. I agree with the search sprint idea

but still - if it's an improvement why not throw it on and see if it helps (by some smart GA tracking somehow)

mzedeler commented 11 years ago

The commits are already integrated on LYT/master, so they'll be included in the next release.

I have talked to @everhoej about a general accessibility sprint some time in Q3. We agreed to create milestones for the sprint and start collecting the relevant issues there.

simmoe commented 11 years ago

Super - we can close then?

Den 08/05/2013 kl. 13.43 skrev Michael Zedeler notifications@github.com:

The commits are already integrated on LYT/master, so they'll be included in the next release.

I have talked to @everhoej about a general accessibility sprint some time in Q3. We agreed to create milestones for the sprint and start collecting the relevant issues there.

— Reply to this email directly or view it on GitHub.

LDHgithub commented 11 years ago

Yes, we just have to make sure that the service ”mobileSearch” is installed with the new release – and that the new storedprocedure is present on catalogSearch…..

Fra: Simon [mailto:notifications@github.com] Sendt: 8. maj 2013 15:07 Til: Notalib/LYT Cc: Lars Daldorph Emne: Re: [LYT] Spelling mistakes (#482)

Super - we can close then?

Den 08/05/2013 kl. 13.43 skrev Michael Zedeler notifications@github.com<mailto:notifications@github.com>:

The commits are already integrated on LYT/master, so they'll be included in the next release.

I have talked to @everhoej about a general accessibility sprint some time in Q3. We agreed to create milestones for the sprint and start collecting the relevant issues there.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/Notalib/LYT/issues/482#issuecomment-17604181.

mzedeler commented 11 years ago

We can close this issue once it has been tested.

mzedeler commented 10 years ago

Tasks:

points: 3.

everhoej commented 10 years ago

Done.