search

Notalib / LYT

m.e17.dk
GNU Lesser General Public License v3.0
10 stars 12 forks source link

Remove local test server (and tests) #568

Closed saebekassebil closed 10 years ago

saebekassebil commented 10 years ago

There's a lot of "dead code" in the library, this includes the tests, written in QUnit in test/. They're there but they are failing, and originates from around 2011-12.

There's also the "local test server" in tools/server which to my understanding isn't used at all (or very little). If this is true, it should probably be removed, since this could remove a lot of redundant code form the repository (actually the whole tools folder could be removed).

Unit tests and a local server would be nice to have - but only if they work properly.

mzedeler commented 10 years ago

Agreed. Feel free to remove the test stuff, but note that the player also incorporates a test page (separate from the local test server and the stuff in test/) that we shouldn't remove.

saebekassebil commented 10 years ago

Pulled in b86bca1c03bb2e92350a5645ef970802a004129c and 58c6dc0185a41c4d1e2ba62d268eebb4ab37448d