Notalib / LYT

m.e17.dk
GNU Lesser General Public License v3.0
10 stars 12 forks source link

Reintroduce linting tasks in Cakefile for both HTML and CoffeeScript #587

Closed saebekassebil closed 10 years ago

saebekassebil commented 10 years ago

This PR creates two new tasks in the Cakefile:

The CoffeeScript linting is going to be a really nice feature once we've cleaned up the existing code. Then we can just check that our newly written source code complies to our style standards every time we want to do a pull request/merge. At the moment we get quite a few linting errors, and we'll also have to agree on some coding style standards, but for now I've disabled two features in the lint process, that I'd like to enable at some point later:

These linting rules live in a lint config file I've called .coffeelint.json. If you'd like to call it something else, let me know and I'll change it.

mzedeler commented 10 years ago

If you try running cake lint:coffee without having coffeelint installed, an error should be output (or at least a warning).

Besides that, this looks allright.

saebekassebil commented 10 years ago

@mzedeler: I've changed the code so that coffeelint is now a dependency. The Cakefile will not run if there hasn't been issued a $ npm install command, so we're sure that coffeelint will be in there if the cake lint:coffee task is run.

Ready for merge?

jarl-dk commented 10 years ago

:+1: