StellarPooledNBT causing crash with Thermal Expansion

NovaEngineering-Source / StellarCore

Full range of optimization for a better 1.12.2.

https://www.curseforge.com/minecraft/mc-mods/stellarcore

GNU Lesser General Public License v3.0

35 stars 8 forks source link

StellarPooledNBT causing crash with Thermal Expansion #22

Closed sainagh closed 3 days ago

sainagh commented 2 weeks ago

The issue shows up with stellarcore-0.5.13. It is not present in prior versions.

The game fails to launch due to a crash that mentions stellarcore's StellarPooledNBT mixin method and thermal expansion.

I suspect this may be an issue with the new MBT optimization that was added in the latest version of the mod.

Crash report is attached.

Crash-latestStellarCore.txt

sainagh commented 2 weeks ago

Please let me know if there is anything I can do for debugging

KasumiNova commented 2 weeks ago

can provide a full log?

sainagh commented 2 weeks ago

Here is the full log latest.log

KasumiNova commented 2 weeks ago

Maybe mixin is broken by other mods, try disable NBTPrimitiveConstantsPool option?

sainagh commented 2 weeks ago

Ok, changing the config removed the crash, thanks for checking!

jchung01 commented 2 weeks ago

In this case, it seems to be caused by Mob Population Control (MobPC) loading NBTBase too early (re-entrant transformer). Minimal set of mods to cause a crash is:

ConfigAnytime 3.0
MixinBooter 9.2
MobPC 1.0.0.0
Stellar Core 1.5.13
Universal Tweaks 1.13.0

debug.log: https://mclo.gs/XXQmedZ Removing MobPC or disabling the NBTPrimitiveConstantsPool "fixes" it. Re-entrant transformers seems to be a pretty recurring problem with ASM coremods and mixin mods...