NovaEngineering-Source / StellarCore

Full range of optimization for a better 1.12.2.
https://www.curseforge.com/minecraft/mc-mods/stellarcore
GNU Lesser General Public License v3.0
35 stars 8 forks source link

(Suggestion) "Minimap FPS Limiter" type of feature for Xaero's Minimap #23

Open IdkWhatNameThingyToPut opened 2 weeks ago

IdkWhatNameThingyToPut commented 2 weeks ago

Hello I'm not sure if your aware but there is actually in my opinion too a really important feature regarding one of if not the best minimap mods out there where you can limit the minimaps FPS which the feature itself comes from a mod called XaeroPlus (https://www.curseforge.com/minecraft/mc-mods/xaeroplus). The performance boosts that you can get from this actually look to be massive. Like hundreds of FPS.

Here's a video from the XaeroPlus mod's main page on CurseForge: https://www.youtube.com/watch?v=hIG-VyGQLao

As you can see it's a lot of gained FPS with the limiter on so this feature seems pretty important.

However this feature seems to be only available for "1.19+", I spoke to the developer of the mod XaeroPlus and they said "Yeah I have no plans to backport it.", they also said "But if someone wishes to contribute a backport or reimplement it in their own mod both are fine with me." which all of that you can find here: https://github.com/rfresh2/XaeroPlus/issues/179

Hoping you can make your own type/implementation of a feature like this to your mod it would be amazing.

KasumiNova commented 2 weeks ago

try HUDCaching option?

IdkWhatNameThingyToPut commented 2 weeks ago

try HUDCaching option?

Sorry I can't find that option what config file and stuff is it in?

Quick update I just realised you were talking about your own mods config files I'm definitely gonna give that a try sounds interesting thanks

IdkWhatNameThingyToPut commented 2 weeks ago

I'm going to test that option out and I'll get back to you here.

IdkWhatNameThingyToPut commented 2 weeks ago

I tested this out and the results are amazing performance-wise.

With your mod's HUDCaching option off I was getting around 1800 FPS: Minecraft_2024 11 06-14 12

With your mod's HUDCaching option on I was getting arounded 2400 FPS: unknown_2024 11 06-14 18_1

Btw to see FPS look at optifine's FPS counter in the top left corner of both screenshots ignore the FPS counter on the top right that's the FPS Reducer mod's FPS counter that seems to also be capped by your mods HUDCaching option on the 2nd screenshot.

The only thing I have to really say about it is if anyone tries this I would probably change I:HudCachingFPSLimit=20 to something a little bit higher because the map does look a bit choppy when it's rotating around and stuff, but I actually am going to look into whether there's settings or not to stop the Xaero's minimap from rotating because if that is the case then the 20 FPS cap probably is fine or maybe a little higher 30-40 even who knows but I'd like to see if that map can be stopped from rotating because it seems be the main part of stuff that could make things look choppy from the 20 FPS limit.

IdkWhatNameThingyToPut commented 2 weeks ago

There is a "Lock Minimap North" feature in Xaero's Minimap and after enabling it I didn't notice choppiness as much from your mod limiting the FPS of the map since the map is no longer rotating. Seems a lot better this way.

IdkWhatNameThingyToPut commented 2 weeks ago

Hmm while testing your StellarCore mod I noticed I was getting purple textures heaps, it seems to be happening when both StellarCore and Optifine (specifically preview_OptiFine_1.12.2_HD_U_G6_pre1.jar) are installed in the same modpack together. I don't see it said anywhere so I'm going to ask here now is StellarCore incompatible with Optifine? That's a deal breaker for me if so, I really want some type of minimap FPS limit stuff but I also want it working with optifine because that'd be amazing for performance and use of shaders would be possible which I want. If you don't care about shaders that's fine but some people do so to each their own.

Minecraft_2024 11 06-15 37

Btw in that screenshot I think those are pumpkins that have the purple textures

IdkWhatNameThingyToPut commented 2 weeks ago

Turning on the HUDCaching option seems to conflict with BSL Shaders Aurora thingy at night time (it gives a black screen)

With HUDCaching option on: Minecraft_2024 11 07-17 09

With HUDCaching option off: Minecraft_2024 11 07-16 16

The Aurora can be disabled I think which I haven't tested yet. Why haven't I tested it? Because unless you have a $1 million dollar alien technology PC there's no point talking about shaders or me testing stuff like this with shaders on modded minecraft 1.12.2 until https://github.com/NovaEngineering-Source/StellarCore/issues/20 is solved. 6 render distance = potentially 300+ FPS with shaders, 10 render distance = barely 100 FPS with shaders. However mob spawning is bugged on lower render distances so your stuck with 10. I'm telling you the one who solves that problem is the one who made shaders really viable on 1.12.2 and maybe even more modded minecraft versions

KasumiNova commented 2 weeks ago

Hmm while testing your StellarCore mod I noticed I was getting purple textures heaps, it seems to be happening when both StellarCore and Optifine (specifically preview_OptiFine_1.12.2_HD_U_G6_pre1.jar) are installed in the same modpack together. I don't see it said anywhere so I'm going to ask here now is StellarCore incompatible with Optifine? That's a deal breaker for me if so, I really want some type of minimap FPS limit stuff but I also want it working with optifine because that'd be amazing for performance and use of shaders would be possible which I want. If you don't care about shaders that's fine but some people do so to each their own.

Minecraft_2024 11 06-15 37

Btw in that screenshot I think those are pumpkins that have the purple textures

This problem seems to occur randomly at the moment and no specific cause has been found yet, or you can turn off the ParallelModelLoader option.

IdkWhatNameThingyToPut commented 2 weeks ago

Hmm while testing your StellarCore mod I noticed I was getting purple textures heaps, it seems to be happening when both StellarCore and Optifine (specifically preview_OptiFine_1.12.2_HD_U_G6_pre1.jar) are installed in the same modpack together. I don't see it said anywhere so I'm going to ask here now is StellarCore incompatible with Optifine? That's a deal breaker for me if so, I really want some type of minimap FPS limit stuff but I also want it working with optifine because that'd be amazing for performance and use of shaders would be possible which I want. If you don't care about shaders that's fine but some people do so to each their own. Minecraft_2024 11 06-15 37 Btw in that screenshot I think those are pumpkins that have the purple textures

This problem seems to occur randomly at the moment and no specific cause has been found yet, or you can turn off the ParallelModelLoader option.

Hmm yeah I just did some more testing and it does it seem to be random in what textures become purple but the problem happening and there being purple textures doesn't seem random like I can very easily reproduce this problem with my testing modpack. Removing optifine from the testing modpack seems to stop the purple texture problem from happening. I guess I'll have to use that option until this is all figured out though thank you.

Here's a mod list I dumped with the Tellme mod to help you reproduce the issue: mod-list_2024-11-07_18.38.14.txt Just make sure you install optifine (preview_OptiFine_1.12.2_HD_U_G6_pre1.jar) with those mods and hopefully you should be able to reproduce the issue so you can look into it better and fix it.