search

NovoG93 / vision_msgs_rviz_plugins

RVIZ2 plugins for visualization of vision_msgs
Apache License 2.0
71 stars 7 forks source link

Old markers persist in detection3DArray marker view. #4

Open MyronRodrigues-StreetDrone opened 1 year ago

MyronRodrigues-StreetDrone commented 1 year ago

Thanks for this plugin.

Tested this out on a node and the detection visualisations work fine with edges only view, however on the marker view I get boxes that persist for quite some time, I'm guessing these are with ID's that don't get replaced with the same ID. Since these are detections and if users try to set the ID to the class of detections I think the old markers need to me cleared before publishing new ones? I'd written a node previously for this issue: it would publish a remove marker before any other markers.

I've tried adding

m_marker_common->clearMarkers();
// also
m_marker_common->deleteAllMarkers();

below but doesn't seem to help.

https://github.com/NovoG93/vision_msgs_rviz_plugins/blob/20d4012c64048a65e2dbb2aff9ea93765909e751/include/vision_msgs_rviz_plugins/bounding_box_3d_common.hpp#L83

NovoG93 commented 1 year ago

Thanks for pointing this out, I will look into it when I find time. Could you maybe provide me a rosbag where this happens?