Crash when using PNG as texture for a md5 model

Novum / vkQuake

Vulkan Quake port based on QuakeSpasm

GNU General Public License v2.0

1.85k stars 224 forks source link

Crash when using PNG as texture for a md5 model #752

Closed NurglesHogweed closed 3 days ago

NurglesHogweed commented 3 days ago

Engine version: "master" from november 12, for Linux. Error text:

vkquake: ../Quake/gl_texmgr.c:694: TexMgr_Downsample: Assertion `(out_width >= 1) && (out_width < in_width)' failed.

The texture I tried to use is 256x256. FTEQW, QSS and fimg have no problems with it.

vsonnier commented 3 days ago

Hello @NurglesHogweed, please provide the necessary files and procedure to reproduce this use case.

NurglesHogweed commented 3 days ago

You can extract, for example, pak0.pak\progs\v_shot_00_00.lmp, convert it to PNG, put it to id1\progs and see what happens. Of course, remastered model option must be ON.

vsonnier commented 3 days ago

Thanks, that was useful. Turns out the texture support in MD5 was not completly ported from QSS, only .lmp really worked. This is now fixed I think. I've tried with both 8bit and 24bit .png and also .pcx and it seems to work.