NuGrid / NuGridPy

Python tools to access and analyse NuGrid output data (including from MESA)
http://nugrid.github.io/NuGridPy
BSD 3-Clause "New" or "Revised" License
13 stars 10 forks source link

Replace set_nice_params() function with mathplotlib custom style sheets? #74

Open Samuel316 opened 5 years ago

Samuel316 commented 5 years ago

Why don't we replace this function with a custom NuGrid Style sheet so all the plots are by default both consistent and publication ready (There could even be different sheets for posters, presentations, and different journals).

https://matplotlib.org/tutorials/introductory/customizing.html https://matplotlib.org/api/style_api.html?highlight=style%20use#matplotlib.style.use

https://github.com/NuGrid/NuGridPy/blob/629d9efca71680e42e66e2e9c54217608b9400d8/nugridpy/mesa.py#L155-L172

fherwig commented 5 years ago

Sam, that’s a great idea. Check with Adam if you can submit the necessary changes as a pull request at this time. You should also add maybe an example notebook to the wendi-examples repository and let people know about it. Falk.

On Sep 8, 2019, at 10:46 PM, Samuel Lloyd notifications@github.com<mailto:notifications@github.com> wrote:

Why don't we replace this function with a custom NuGrid Style sheet so all the plots are by default both consistent and publication ready (There could even be different sheets for posters, presentations, and different journals).

https://matplotlib.org/tutorials/introductory/customizing.html<x-msg://11/url> https://matplotlib.org/api/style_api.html?highlight=style%20use#matplotlib.style.use<x-msg://11/url>

https://github.com/NuGrid/NuGridPy/blob/629d9efca71680e42e66e2e9c54217608b9400d8/nugridpy/mesa.py#L155-L172

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/NuGrid/NuGridPy/issues/74?email_source=notifications&email_token=ACQZMJTCZNASGX5ZSIT3PDTQIVQB7A5CNFSM4IUUZLDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HKBCS5A, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACQZMJSL2WXV5V5BF2V37TDQIVQB7ANCNFSM4IUUZLDA.

-- Falk Herwig Dept of Physics & Astronomy, U of Victoria fherwig@uvic.camailto:fherwig@uvic.ca, tel: +1 (250) 721-7743

Samuel316 commented 5 years ago

I've demonstrate that what I suggested can work in practice in branch issue74. If Adam thinks that a real implementation is possible then we begin to design some sort of default style and leave the implementation until after changes in the code settle down.

I think that what I've done only works if you use the -e option with pip during install, it's probably best to include something in the setup file like this? https://stackoverflow.com/questions/35851201/how-can-i-share-matplotlib-style that adds the style to matplotlib.