Make Bios test is great and green again - Githubissues

NubeIO / iot-engine

IoT Engine

5 stars 1 forks source link

Make Bios test is great and green again #256

Open zero88 opened 5 years ago

zero88 commented 5 years ago

Brief Follow up to #251 Currently, disable almost test in https://github.com/NubeIO/iot-engine/tree/8cb5028ed087a33d98607cb6b7a25918ea4554c5/edge/bios/src/test/java/com/nubeiot/edge/bios

DOD

[x] Understand #251
[x] Identify what business case, coverage of bios test
[x] Refactor and move all tests from :edge:bios into :core:installer. Must be follow a skeleton: https://github.com/NubeIO/iot-engine/blob/8cb5028ed087a33d98607cb6b7a25918ea4554c5/core/installer/src/test/java/com/nubeiot/edge/installer/BaseInstallerVerticleTest.java#L28 https://github.com/NubeIO/iot-engine/blob/8cb5028ed087a33d98607cb6b7a25918ea4554c5/core/installer/src/test/java/com/nubeiot/edge/installer/service/MockDeploymentService.java#L12-L13 https://github.com/NubeIO/iot-engine/blob/8cb5028ed087a33d98607cb6b7a25918ea4554c5/core/installer/src/test/java/com/nubeiot/edge/installer/service/MockFinisherService.java#L5-L6