search

NuclearPowered / Reactor

Modding api for Among Us
https://reactor.gg
GNU Lesser General Public License v3.0
225 stars 43 forks source link

improve kick message for players without reactor #82

Closed whichtwix closed 2 months ago

whichtwix commented 3 months ago

Currently players get confused when they see reactor as the reason for their friends getting kicked from lobbies, at least due to not knowing what reactor is. The pr changes the message to indicate they don't have mods required by all players.

js6pak commented 2 months ago

Thanks for the PR, but it has a few issues. Firstly officials will "ban" you for either bypassing the chat cooldown or the message length limit. And because you manually create the modsList string instead just using string.Join you will always end up with a comma at the end.

js6pak commented 2 months ago

image

Pietrodjaowjao commented 2 months ago

and ALSO illegal string

Pietrodjaowjao commented 2 months ago

reactor should have a custom rpc for this instead

js6pak commented 2 months ago

and ALSO illegal string

New lines are fine for now at least, we can change it to a comma later if needed.

reactor should have a custom rpc for this instead

This whole kicking mechanic is only used when both the server doesn't have Reactor handshake support (so on officials) and the joining player doesn't have Reactor installed at all. In any other case they will be kicked either by the server^1 or the host with a custom GameData message^2.