Nukesor / pueue

:stars: Manage your shell commands.
Apache License 2.0
5.03k stars 133 forks source link

Add NetBSD support #568

Closed 0323pin closed 2 months ago

0323pin commented 2 months ago

Hi,

I've packaged pueue for NetBSD and the package has been merged into pkgsrc main branch. Commit log for reference, https://mail-index.netbsd.org/pkgsrc-changes/2024/09/19/msg307405.html

Now, in order to do this, I needed to add support to the relevant files, this PR.

The software is tested and works as expected. For the package, we are currently using my fork as upstream. Hence, I cannot squash the commits since that would generate a new checksum and break the builds on our servers. Hopefully, you can do the commit squash when merging.

Once merged, I will regenerate all checksums and shift upstream to the proper one, i.e. your master.

Thanks!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.28%. Comparing base (1c5f4aa) to head (7c5ca49).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #568 +/- ## ========================================== + Coverage 78.21% 78.28% +0.06% ========================================== Files 75 75 Lines 5844 5835 -9 ========================================== - Hits 4571 4568 -3 + Misses 1273 1267 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Test Results

  3 files  ±0   19 suites  ±0   3m 4s :stopwatch: -1s 161 tests ±0  161 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  340 runs  ±0  340 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7c5ca49a. ± Comparison against base commit 1c5f4aa0.

Nukesor commented 2 months ago

Looks good to me :) Don't worry about the commits, as long as they're sensible, there's no need to squash.

Lints have been addressed on the main branch. Not sure why they pop up though, I don't get them on my local machines, they only show up in CI o.O

0323pin commented 2 months ago

Cheers! I'll shift to your repository sometime during the weekend.