Nuklon / Steam-Economy-Enhancer

Enhances the Steam Inventory and Steam Market.
MIT License
1.59k stars 181 forks source link

Showing of the lowest listed price for items in inventory and trade offers. #19

Closed Botan626 closed 7 years ago

Botan626 commented 7 years ago

Hello, Nuklon.

Could you, please, add an option to turn this feature on and off, as it seems to slow down the perfomance of actions highly when having a big inventory.

Nuklon commented 7 years ago

How many items are we talking about? I've no issues with it with 50 pages of items.

Botan626 commented 7 years ago

135 pages, but had freezes with lower amount of pages.

Doing a simple task like moving 90 items from single game to bot account causes this problem, for instance. When starting typing in the search field for a specific item, it all just halts.

Turning script off solves the issue. Using SIH for the option to select all items on page causes no problems.

But I really want to use this script only for the relisting option.

Botan626 commented 7 years ago

It literally takes 25 seconds to load card info for selling after the search for specific game was taken in the inventory.

Nuklon commented 7 years ago

Please checkout the latest commit, it should perform much better with large inventories.

The loading of the prices is all done async (was already like that) and should not cause any additional lag. What was laggy was observing the children in the trade offer window, I've now reduced this to a much smaller part of the window and everything now loads almost immediately.

Botan626 commented 7 years ago

Same, no changes.

What data I can provide you to help with this?

Nuklon commented 7 years ago

Step by step to reproduce might help.


From: Botan626 Sent: Thu Jun 01 20:56:24 GMT+02:00 2017 To: Nuklon/Steam-Economy-Enhancer Cc: Nuklon , State change Subject: Re: [Nuklon/Steam-Economy-Enhancer] Showing of the lowest listed price for items in inventory and trade offers. (#19)

Same, no changes.

What data I can provide you to help with this?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/Nuklon/Steam-Economy-Enhancer/issues/19#issuecomment-305586999, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWQlwR5y3C431YCng6G76GCFYPEV-LFwks5r_wlYgaJpZM4NqCMR.

Botan626 commented 7 years ago

How to get it done?

omicron321 commented 7 years ago

The problem is not listing lowest prices. Pages are downloaded in a few seconds. jQuery is bottlenecking DOM/jQuery objects manipulation.

Botan626 commented 7 years ago

Is jQuery a part of SEE or Steam itself?

Is there anything can be done re this?

At present time I do like this:

  1. Disable SEE.
  2. Install SIH.
  3. Create market orders with SIH.
  4. Uninstall SIH.
  5. Enable SEE.
  6. Relist overpriced items with SEE if needed.
  7. Disable SEE for possible trades.
Nuklon commented 7 years ago

jQuery is part of both SEE and Steam. But I could finally reproduce this in the trade offer window, please try the latest build.

Botan626 commented 7 years ago

Works fine with the trade offers, but still lagging perfoming inventory actions.

Nuklon commented 7 years ago

Please check again if this helps on the inventory. This is about as good as I can get it I think.

Botan626 commented 7 years ago

Still takes 13-15 seconds to load info on a card to sell.

Nuklon commented 7 years ago

Do you have a public inventory? Please give me a link so I can try it out myself on yours.

Botan626 commented 7 years ago

Here you go:

http://steamcommunity.com/id/Botan626/inventory/

Nuklon commented 7 years ago

If I have SEE disabled it's also very slow on your inventory, with or without it's the same.

Botan626 commented 7 years ago

Try to search for "jet racing" items in my inventory, for example.

Once the images are loaded, the selection between them takes nothing (time) with SEE disabled (same with SIH).

If SEE enabled, it's around 15 seconds.

Nuklon commented 7 years ago

Takes 5 seconds without SEE in all browsers here, well, except Edge, which seems to give up after a minute or so. If all images are loaded it takes <1 second in Firefox and Chrome, with or without SEE.

Did you force SEE to update?

Botan626 commented 7 years ago

Did you force SEE to update? -- Of course, 4.8.0 installed.

For me it takes 12-15 seconds. Shift selection takes twice longer.

Nuklon commented 7 years ago

OK, well, I can't reproduce it, I don't have such a big inventory myself but just browsing your inventory from the outside is as fast with as it is without. You'll have to see what's causing it yourself.

Botan626 commented 7 years ago

You'll have to see what's causing it yourself. --- I have no idea how this could be done.

Botan626 commented 7 years ago

Plus, you just turned it's functionality off in other people's inventories, and I have no issues browsing strangers' inventories too.

Nuklon commented 7 years ago

If you go to this part:

// Ignore selection on other user's inventories. if (!isOwnInventory) return;

make it like this:

// Ignore selection on other user's inventories. // if (!isOwnInventory) return;

How's the performance then?

Botan626 commented 7 years ago

I just need to edit it in Tampermonkey and press floppy disk button?

Well I did this, and it works fast and smooth, though no green buttons appeared there.

I tried this one: https://steamcommunity.com/id/laume_kurai/inventory/

Botan626 commented 7 years ago

I added you to friends in Steam for conversation.

Nuklon commented 7 years ago

You should try it out on your own inventory. What you're missing then should be the quick sell buttons on the right side + inventory selections, the rest of the script should work completely.


From: Botan626 Sent: Sun Jun 04 17:08:30 GMT+02:00 2017 To: Nuklon/Steam-Economy-Enhancer Cc: Nuklon , State change Subject: Re: [Nuklon/Steam-Economy-Enhancer] Showing of the lowest listed price for items in inventory and trade offers. (#19)

I added you to friends in Steam for conversation.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/Nuklon/Steam-Economy-Enhancer/issues/19#issuecomment-306045726, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWQlwXMXktBLTnxtLHNoOn_A484s0StYks5sAshugaJpZM4NqCMR.

Botan626 commented 7 years ago

I have no sell buttons on the right side, but 3 buttons above inv. are still there. What are inventory selections buttons?

With that done, works fast and smooth.

see

Botan626 commented 7 years ago

Maybe it has something to do with the currency, Rub?

Botan626 commented 7 years ago

New info:

I manually navigated through my inventory to page 80 or so, and while doing it cards were selected with no trouble and multiple selection worked smooth.

As soon as I put "jet racing" in the search field, it all crashed, the tab doesn't respond for 3 mins already.

Nuklon commented 7 years ago

Unlikely (the currency), the buttons above are added elsewhere and that doesn't change, it's just the information on the right side that's different. I'll chat to you on Steam when you're online and see if we can narrow it down.