search

Nuklon / Steam-Economy-Enhancer

Enhances the Steam Inventory and Steam Market.
MIT License
1.59k stars 181 forks source link

Infinite "Loading market listings" #8

Closed yarushi closed 7 years ago

yarushi commented 7 years ago

I would like to refresh my item prices but keep showing this "Loading market listings"

ac3ead233af04a93b6a67ed645203e22

Nuklon commented 7 years ago

Several questions:

yarushi commented 7 years ago

1) Chrome 2) Not working with English 3) Not working with hard refresh too

Nuklon commented 7 years ago

Alright, I can't reproduce it. I've tested it on 3 different machines (Chrome + Firefox) and it's working on all of them. Maybe you can try it on another browser?

Sparh4wk commented 7 years ago

have exactly the same problem in chrome :( infinite loading market listings :(

UPDATE: just tryed on firefox, fresh installation, yet, same problem :(

btw its doing the same thing even if I dont have anything or market:

w39tqhb

Nuklon commented 7 years ago

Does anything related to an error show up in the developer's console (F12)? I'd like to fix it of course but as I can't reproduce it it's impossible for me.

Sparh4wk commented 7 years ago

Dunno if its related.. on chrome Ive got this after market refresh. i63uh2z

and firefox:

z3eklcu

Nuklon commented 7 years ago

I don't think so, no, I have that as well and it's working fine here. If you log network connections (Net) in Firefox, does anything show up there? It should make connections such as: http://steamcommunity.com/market/mylistings?count=100&start=0 http://steamcommunity.com/market/mylistings?count=100&start=100

If you manually enter that url in the browser, does that print anything that's related to your listings?

Sparh4wk commented 7 years ago

yes, if I enter those urls to chrome or firefox, it does print info about my listings.

Nuklon commented 7 years ago

Alright, so that's at least working then. I pretty much need someone with this issue that has some coding experience and can help me debug this.

omicron321 commented 7 years ago

Hello, thanks for your great script. I think I also had this problem... I don't know how I fixed it.... Maybe just (dis)enabling the userscript. Or messing with EnhancedSteam.

Also, the page navigation disappear : http://i.imgur.com/i3DO7HX.png

Nuklon commented 7 years ago

Page navigation is removed as all listings are loaded, it's pointless.

omicron321 commented 7 years ago

The page only lists 100 items : http://i.imgur.com/onUzqTi.png While I have 1000+ items for sale.

omicron321 commented 7 years ago

parseInt... http://i.imgur.com/hN2CnG6.png :P

omicron321 commented 7 years ago

Fixing it and making it display 1000+ market items is very heavy at the moment anyway...

yarushi commented 7 years ago

Not working with firefox too :/

omicron321 commented 7 years ago

Here a quick-fix to apply : http://i.imgur.com/gO5V1O1.png but be aware page will be slow at beginning if you have lots of items on sale...

yarushi commented 7 years ago

Thanks, It's working now. But the relist button seems get removed, or is it just here ?

Sparh4wk commented 7 years ago

so I just found a weird thing... if my market list is < 10 items = infinite loading if my martket list is > 10 items = I can see list without infinite loading

hopefully this will helps you :)

Nuklon commented 7 years ago

Alright, I don't have 1000+ items so I couldn't test that. I already had a function to replace non numbers so I've changed that.

I have about 800 listings at market place without any performance issues (Firefox). Ideally I'd like to keep the pagination but this is problematic because the content is loaded async (every time to go to another page, even back) it's hard to show progress or any kind of feedback that's useful to the user. I think I can add some 3rd party pagination, I'll check it out later.

Regarding the listings, I'm not sure why that happens with < 10 items. Did you find any reason why?

omicron321 commented 7 years ago

I haven't looked for < 10 items yet.

I have tested main market page. With 2000+ listed items. (thanks to your script !) Script's performance is MUCH better on Firefox than Chrome ! And performance tools much better and useful in a first approach... (but afaik, sadly Firefox doesn't offer unminifying on the fly)

Also, I found a typo... not sure how _gbmarketwindowhidden is working, though. injectjs unknown, because it is supposed to be injectJs http://i.imgur.com/FjgZq1v.png

omicron321 commented 7 years ago

Oh, and those buttons appear on Firefox... but not in Chrome http://i.imgur.com/3ptBGTP.png ...but adding items to market is failing for some reasons on Firefox on my side... o_o

Sparh4wk commented 7 years ago

nope I didnt find anything, why < 10 items = infinite loading :( but I can say for sure, that there is something wrong.. tryed that several times, and always same result

Nuklon commented 7 years ago

Firefox absolutely has a unminify option (Automatically black box minified sources). I personally only use Firefox, never been a fan of Chrome.

For some reason the injectJs code was put to lower case, not sure when that happened but it's an easy fix (already did that).

I'll investigate the < 10 items bug too, I'll just have to remove all my 800 listings and try again, it's not that hard. I'm currently adding some pagination and a search for market listings, but I still need to style it.

Nuklon commented 7 years ago

Please try out 3.5.0 :)

Sparh4wk commented 7 years ago

niiiiiiice 👍 its working now

Nuklon commented 7 years ago

Including < 10 items?

Sparh4wk commented 7 years ago

yes, good job! 👍

omicron321 commented 7 years ago

It works quite well.

Nuklon commented 7 years ago

I'm not using Enhanced Steam, I already made some changes regarding sorting and ES but I'm not really looking into coding a ton of extra stuff just to get around it. I accept PRs for this if anyone is feeling up to it.

Regarding the sorting: price is easy, as it's just a few numbers. sorting by name too (just using default js sort). Sort by date relies on Date.js, If there's a better library it shouldn't be too hard to use but I've yet to find one (+ localized preferably). It works rather well in English at least.

The misplaced search box, there shouldn't be on for those listings, should be fixable.

Nuklon commented 7 years ago

BTW, the maximum price is used for items that have no sell orders. Buy orders are only used if their price exceeds the calculated price (extremely unlikely) or if their price exceeds your maximum defined price (for example, you have the max set to 25 cents, a buy order wants to give 30 cents -> it will list it for 30 cents). This is the expected behavior and it's what I want, it doesn't make sense from an economic point of view to take your minimum price for example.

omicron321 commented 7 years ago

I am talking about that kind of cases : http://i.imgur.com/jOSskWG.png No buying offers => the autosell will use max price. At least, that is what I get like 99% of cases. Though, it doesn't matter for me anymore. Everything from my inventory went on sale. And I (or anyone) can force very low max price if needed.

About ES : As ES is quite use, some people might want to be aware of temporary fix when they want to use Steam-Economy-Enhancer. As ES is injecting scripts a bit everywhere on Steam, it should ES responsibility to offer more options to disable what it does on market page.

Nuklon commented 7 years ago

Can you also send me one of these cards that's 100% certain causing issues? This should also be fixed then 👍

Nuklon commented 7 years ago

Fixed the search box, the rest seems to fixed in here.

Botan626 commented 7 years ago

Hello. Just installed this extension, and I'm having this issue.

Sparh4wk commented 7 years ago

yes, the issue < 10 = infinite loading is back :(

omicron321 commented 7 years ago

yarushi lately too, but fixed it by resetting his browser.

Nuklon commented 7 years ago

I'll investigate this again.

Nuklon commented 7 years ago

I think I found the problem and have fixed it, will upload a new version in a sec.