search

Null-MC / Shrimple

A simple Minecraft Java shader that attempts to maintain the vanilla aesthetic while adding optional shadows & colored lighting.
Other
131 stars 6 forks source link

[1.19.2] Crash on enable with iris 1.6 #6

Closed itsdinkd closed 1 year ago

itsdinkd commented 1 year ago

Attempted to use in my modpack AQM2.

Crashed immediately after enabling.

Version 0.7 Shrimple https://gist.github.com/itsdinkd/b7c0921d67240bf07ecb384346e3f9b9

null511 commented 1 year ago
itsdinkd commented 1 year ago

Not a mod conflict as I was testing a different shader before I switched to yours.

Not for redistribution? So you don't want it in my modpack? Got it. Please close this ticket then.

On Tue, Apr 11, 2023, 2:38 PM Joshua Miller @.***> wrote:

  • This looks like a mod is conflicting with Iris and not related to the shader at all.
  • Shrimple doesn't allow redistribution with owner permission.
  • You need the latest Iris 1.6.0 if you want to use colored lighting/ray-tracing.
  • The next official release, and first public 1.0 release, will be within next few days.

— Reply to this email directly, view it on GitHub https://github.com/Null-MC/Shrimple/issues/6#issuecomment-1504124172, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIL5CKDYOWJSWLM3I3K4APLXAXFNZANCNFSM6AAAAAAW22A6XQ . You are receiving this because you authored the thread.Message ID: @.***>

null511 commented 1 year ago

I didn't say whether I was interested or not, but redistributing other peoples products when the license prohibits it is illegal.

Not a mod conflict as I was testing a different shader before I switched to yours.

Also not relevant; I'm assuming you don't know how to read a stack trace because it tells you what the conflict is. Mod mixins are not shader related, and there is no error here related to Shrimple.

itsdinkd commented 1 year ago

I never said I was shipping it out. I said i attempted to use it. Whole purpose of me mentioning my modpack was so that you could be aware of what to use for your tests if it went that far. Why would I ship something out that's broken?

Second, your shader is on Curseforge. adding it to a curseforge modpack is not redistributing and does not break any laws PER Curseforge TOS. your definition is widely loose. Please learn the law before blindly calling something illegal.

yes I know how to read a stacktrace. your shader obviously caused issues with iris. there might be a conflict somewhere, but it is stemming for your shader pack.

null511 commented 1 year ago

Feel free to revisit/open a new issue once you have an error log without the other mods installed, as there's nothing in your current log related to shrimple that I can work with.