NullDesk / ticketdesk

TicketDesk - A simple and effective Issue Tracker for Help Desks
Microsoft Public License
258 stars 189 forks source link

Just a small issue with email layouts #140

Closed AGitDev closed 7 years ago

AGitDev commented 7 years ago

I found that the header table of the html emails didn't look right - the right hand cell was a different height in various email clients. The change I propose is as below, which corrects the issue (at least for me): File: TicketDesk/TicketDesk/TicketDesk.Web.Client/Views/Emails/Ticket.Html.cshtml

Propsed new lines (76-84):

<td colspan="1" style="font-weight: bold;" rowspan="2">
                    <a href="@((Model.SiteRootUrl??string.Empty).TrimEnd('/'))@Url.Action("Index", "Ticket", new {Id = Model.Ticket.TicketId })">
                        @Model.Ticket.Title
                    </a>
                </td>
            </tr>
StephenRedd commented 7 years ago

I'm going to propose a slightly different change to the layout to get rid of treating this as two rows.

The original structure was a hackish solution for a minor display issue in older version of outlook, but the more recent versions seem to handle this as a single row well enough.

If you could try it out and let me know though, I'd appreciate it:

       <table style="background-color: #B3CBDF;width: 100%;">
            <tr>
                <td style="width: 55px; font-weight: bold; border-right: 1px solid #dcdcdc; text-align: center;">
                    <a href="@((Model.SiteRootUrl??string.Empty).TrimEnd('/'))@Url.Action("Index", "Ticket", new {Id = Model.Ticket.TicketId })">
                        @Model.Ticket.TicketStatus.GetDisplayName()
                    </a>
                </td>
                <td style="width: 40px; font-weight: bold; border-right: 1px solid #dcdcdc; text-align: center;">
                    <a href="@((Model.SiteRootUrl??string.Empty).TrimEnd('/'))@Url.Action("Index", "Ticket", new {Id = Model.Ticket.TicketId })">
                        #@Model.Ticket.TicketId
                    </a>

                </td>

                <td style="font-weight: bold; text-align: left;">
                    <a href="@((Model.SiteRootUrl??string.Empty).TrimEnd('/'))@Url.Action("Index", "Ticket", new {Id = Model.Ticket.TicketId })">
                        @Model.Ticket.Title
                    </a>
                </td>

            </tr>
        </table>
AGitDev commented 7 years ago

Looks fine to me Stephen.

StephenRedd commented 7 years ago

I appreciate you taking the time to look it over. I'll put together a new release as soon as I can wrap up work on a broadcast notification features.