Nullus157 / stylish-rs

Apache License 2.0
8 stars 2 forks source link

Compile `format_args!` to a closure instead of list of pieces. #22

Closed Nemo157 closed 2 years ago

Nemo157 commented 2 years ago

Gives an ~-27% runtime change on a pretty basic benchmark in cbor-diag.

Nemo157 commented 2 years ago

bors r+

codecov[bot] commented 2 years ago

Codecov Report

Base: 58.62% // Head: 56.50% // Decreases project coverage by -2.11% :warning:

Coverage data is based on head (05c0e2e) compared to base (51f2c75). Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## prīmum #22 +/- ## ========================================== - Coverage 58.62% 56.50% -2.12% ========================================== Files 31 32 +1 Lines 841 846 +5 ========================================== - Hits 493 478 -15 - Misses 348 368 +20 ``` | [Impacted Files](https://codecov.io/gh/Nullus157/stylish-rs/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157) | Coverage Δ | | |---|---|---| | [core/src/format.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-Y29yZS9zcmMvZm9ybWF0LnJz) | `0.00% <ø> (ø)` | | | [core/src/io.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-Y29yZS9zcmMvaW8ucnM=) | `21.21% <ø> (ø)` | | | [core/src/lib.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-Y29yZS9zcmMvbGliLnJz) | `100.00% <ø> (ø)` | | | [core/src/std\_compat.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-Y29yZS9zcmMvc3RkX2NvbXBhdC5ycw==) | `100.00% <ø> (ø)` | | | [core/src/string.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-Y29yZS9zcmMvc3RyaW5nLnJz) | `0.00% <ø> (ø)` | | | [core/src/write.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-Y29yZS9zcmMvd3JpdGUucnM=) | `45.45% <ø> (+5.45%)` | :arrow_up: | | [macros/src/to\_tokens.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-bWFjcm9zL3NyYy90b190b2tlbnMucnM=) | `0.00% <0.00%> (ø)` | | | [plain/src/format.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-cGxhaW4vc3JjL2Zvcm1hdC5ycw==) | `80.00% <ø> (-20.00%)` | :arrow_down: | | [style/src/lib.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-c3R5bGUvc3JjL2xpYi5ycw==) | `67.44% <ø> (ø)` | | | [core/src/arguments.rs](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157#diff-Y29yZS9zcmMvYXJndW1lbnRzLnJz) | `100.00% <100.00%> (+7.40%)` | :arrow_up: | | ... and [6 more](https://codecov.io/gh/Nullus157/stylish-rs/pull/22/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nullus157)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bors[bot] commented 2 years ago

Build succeeded: