NvChad / ui

Lightweight & high performance UI plugin for nvchad
GNU General Public License v3.0
166 stars 124 forks source link

Toggle dark/light theme bttn not working propperly #325

Closed n6v26r closed 1 month ago

n6v26r commented 1 month ago

Hey! The toggle theme switch checks for the default in base46, not ui.

So if have something like:

M.ui = {
  theme_toggle = { "catppuccin", "github_light" },
  theme = "catppuccin"
}

The toggle button will give: Set your current theme to one of those mentioned in the theme_toggle table (chadrc) Even if it's set. Idk if this is intentional to use base46, but the documentation shows M.ui as example

Either way, even if I modify M.base46, I can no longer update the default theme from the theme picker.

n6v26r commented 1 month ago

Ok. I saw now that the change is intentional.

siduck commented 1 month ago

@n6v26r yes M.ui is the 1st fallback, but you can add in M.base46 too