OALabs / frida-wshook

Script analysis tool based on Frida.re
128 stars 21 forks source link

frida-wshook seems broken with recent versions of frida.re #2

Open hgabignon opened 5 years ago

hgabignon commented 5 years ago

Hello,

First of all, thank you very much for releasing frida-wshook.

I've tried to run the script with the current version of frida.re (12.6.16) and it seems that the script does not work correctly with this version. I've managed to get it to successfully run with an older version of frida by using a pip install frida==10.1 to force a downgrade successfully.

I've tested with a simple ShellExec script (testing.js)

var shell = WScript.CreateObject("WScript.Shell");
shell.Run("calc.exe");

And here is the result:

> C:\Python27\python.exe .\frida-wshook.py .\testing.js
 [*] x64 detected..using SysWOW64
 [*] Setting Script Vars...
Setting Script Vars...
 [*] Hooking Process 4992
 Press ctrl-c to kill the process...
Microsoft (R) Windows Script Host Version 5.812
Copyright (C) Microsoft Corporation. All rights reserved.

 [!] Warning: Instrumentation script has been destroyed!
 [!] CScript process has terminated!
process-terminated
Traceback (most recent call last):
  File ".\frida-wshook.py", line 53, in on_detach
    print '     |- Process Id: %s' % message.pid
AttributeError: 'unicode' object has no attribute 'pid'

I believe the format of some structures changed in frida which requires probably some changes in the script. Additionally, I had to prefix script vars such as "ADDRESS_FAMILY" with "var " in order to remove some errors.

Dropping this issue for awareness - I will try to get a pull request if I get more time to look at it.

idiom commented 5 years ago

Thanks for the report @hgabignon ! I haven't tested with the newer versions of frida, I'll take a look to get this resolved