OBOAcademy / obook

OBO Organized Knowledge: Training materials for becoming an OBO engineer
https://oboacademy.github.io/obook/
Creative Commons Zero v1.0 Universal
95 stars 38 forks source link

DL query in "Contributing to OBO ontologies" lesson inconsistent with description. #518

Open DominikMartinat opened 1 month ago

DominikMartinat commented 1 month ago

Hello.

This might be wrong place to report it, but the lesson here links to the external tutorial here https://ontology101tutorial.readthedocs.io/en/latest/EXERCISE_BasicDL_Queries.html

There is no information where to contact the author in the external website but since I see @nicolevasilevsky is involved with OBOOK I thought I might post it here.

Issue is that the query bellow is described as finding all classes whose instances have both a U11 snRNP AND or U12 snRNP as parts actually finds all classes whose instances have U11 snRNP as part OR are themselves U12 snRNP class. I have checked that manually in Protege.

image

To work as described, query should be has_part some ('U11 snRNP' or 'U12 snRNP') or has_part some 'U11 snRNP' or has part 'U12 snRNP'.

Similar case is with AND query above it. There it should take the second form as the one using parentheses finds classes with item that have intersection of U11 snRNP and U12 snRNP as part.

If this is the wrong place to report it, feel free to delete the issue.