end-migration scripts of already migrated modules are not executed after resuming a failing migration

pedrobaeza commented 5 years ago

Impacted versions: All

Steps to reproduce: Migrate a DB, complete several module migrations (with end migration scripts), and fail it.

Current behavior: Resuming the migration after fixing the problem, end migration scripts for the already migrated modules are not executed.

Expected behavior: They should be.

It's worth to note that Odoo is also contemplating to allow to resume migrations in https://github.com/odoo/odoo/pull/32634, and they have faced also the end-migration problem.

@Tecnativa

pedrobaeza commented 5 years ago

@hbrunn @StefanRijnhart what do you think about this?

hbrunn commented 5 years ago

I'd wait to see what upstream does and backport that if it's not totally convoluted

StefanRijnhart commented 5 years ago

Agree with @hbrunn

OCA / OpenUpgrade

end-migration scripts of already migrated modules are not executed after resuming a failing migration #1879