OCA / event

Event Management addons
GNU Affero General Public License v3.0
62 stars 166 forks source link

[17.0][MIG] event_registration_partner_unique: Migration to version 17.0 #390

Closed juanjosesegui-tecnativa closed 4 months ago

juanjosesegui-tecnativa commented 4 months ago

@Tecnativa TT49912

Depends on:

pedrobaeza commented 4 months ago

Please check the red CIs, as the module doesn't even install.

juanjosesegui-tecnativa commented 4 months ago

The module depends on partner_event, I suspect it does not install because partner_event is not in version 17.0 of OCA.

chienandalu commented 4 months ago

You're suspicions are funded :smile: push the migration of partner_event so you can move forward on this one :wink:

pedrobaeza commented 4 months ago

/ocabot migration event_registration_partner_unique

If this depends in another PR, you can do: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

pedrobaeza commented 4 months ago

And always put in the main comment such dependency:

Depends on:

- [ ] partner_event: https://github.com/OCA/event/pull/382
pedrobaeza commented 4 months ago

You have ignored this part of the guide:

imagen

juanjosesegui-tecnativa commented 4 months ago

ping @pedrobaeza @chienandalu

chienandalu commented 4 months ago

plase review @carolinafernandez-tecnativa

carolinafernandez-tecnativa commented 4 months ago

Please Squash administrative commits. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.

juanjosesegui-tecnativa commented 4 months ago

@carolinafernandez-tecnativa Done!

carolinafernandez-tecnativa commented 4 months ago

Please check again I still seing administrative commits and pre-commit auto fixes for migration is missing.

carolinafernandez-tecnativa commented 4 months ago

Administrative commits OK

Check please this commit [MIG] event_registration_partner_unique: Migration to 17.0 is empty and you should not change anything related to migration like this examples in pre-commit https://github.com/OCA/event/pull/390/commits/f38a2b929b798a6cced5178c4530c5f9ceca9c14#diff-858e724775ccf6c429de4636fe90cfabad2b2a15ef432cd347a8eab571e0d21dR10 https://github.com/OCA/event/pull/390/commits/f38a2b929b798a6cced5178c4530c5f9ceca9c14#diff-84d67375c5db3c3d8f88527f5e791e6be3011ae1d5e53927986dce40cfb51545R13

carolinafernandez-tecnativa commented 4 months ago

Please Squash administrative commits. There are still some from translation that should be removed. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.

OCA-git-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 4 months ago

/ocabot merge nobump

OCA-git-bot commented 4 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-390-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 4 months ago

Congratulations, your PR was merged at c6b071010df6e6320370510a37651f72b8939ac1. Thanks a lot for contributing to OCA. ❤️