OCA / fleet

Odoo fleet management modules
GNU Affero General Public License v3.0
29 stars 79 forks source link

[17.0][MIG] fleet_vehicle_usage: Migration to 17.0 #161

Open elheit opened 3 weeks ago

ivantodorovich commented 3 weeks ago

Hello!

Thanks for the contribution!

Could you please check the commit history on this PR, it doesn't look right. There are commits/changes involving other modules than fleet_vehicle_usage

elheit commented 3 weeks ago

Hello, at first i want to migrate just the fleet_vehicle_usage module after that i see the issue target modules list so i want to migrate them all so should create a request for each module or just rename this request

marcelsavegnago commented 3 weeks ago

@elheit

Take a look https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

One module per PR please.

elheit commented 3 weeks ago

now it is just one module

pedrobaeza commented 3 weeks ago

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

elheit commented 3 weeks ago

Hello, Yes I have done it this way

pedrobaeza commented 3 weeks ago

I'm afraid not. You haven't respected the previous commit history of the previous contributors of the module. Read my previous message.

elheit commented 3 weeks ago

i have check again and the commit history is from the last commit in the branch 17.0 can you explain to me in more detail what exectly the problem

pedrobaeza commented 3 weeks ago

You haven't preserved all the commit history, which is https://github.com/OCA/fleet/commits/16.0/fleet_vehicle_usage