search

OCA / hr

Odoo Human Resources Addons
GNU Affero General Public License v3.0
219 stars 672 forks source link

[18.0][MIG] hr_employee_firstname: Migration to 18.0 #1397

Closed edy1192 closed 3 weeks ago

edy1192 commented 3 weeks ago

Hi @luistorresm @luisg123v could you check this, please?

Regards.

andreagidaltig commented 3 weeks ago

Hi @luistorresm @luisg123v could you check this, please?

Regards.

LGTM :+1:

luisg123v commented 3 weeks ago

/ocabot migration hr_employee_firstname

OCA-git-bot commented 3 weeks ago

Sorry @luisg123v you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

luisg123v commented 3 weeks ago

Hi @legalsylvain, @pedrobaeza,

I'm not able to mark this PR as a migration one, despite being maintainer, see https://github.com/OCA/hr/pull/1397#issuecomment-2450588614.

Could it be https://github.com/OCA/oca-github-bot/issues/226 is not fully addressed?

CC @yajo

luisg123v commented 3 weeks ago

/ocabot merge nobump

OCA-git-bot commented 3 weeks ago

Sorry @luisg123v you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

moylop260 commented 3 weeks ago

/ocabot merge nobump

OCA-git-bot commented 3 weeks ago

What a great day to merge this nice PR. Let's do it! Prepared branch 18.0-ocabot-merge-pr-1397-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot commented 3 weeks ago

Congratulations, your PR was merged at eece4fb0a895d81c64cf4167664cd3614e40fee6. Thanks a lot for contributing to OCA. ❤️

luisg123v commented 3 weeks ago

/ocabot migration hr_employee_firstname

OCA-git-bot commented 3 weeks ago

Sorry @luisg123v you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

moylop260 commented 3 weeks ago

/ocabot migration hr_employee_firstname