search

OCA / l10n-portugal

Odoo Portuguese localization
GNU Affero General Public License v3.0
4 stars 26 forks source link

[ADD] HR - First public version of new module with the data mode adaptations to the Portuguese law #1

Closed andreparames closed 6 years ago

andreparames commented 9 years ago

This module adds many new fields and mechanisms to the different HR models (Employee, Contract, Payslip, Salary Rules and others), adapting Odoo to the Portuguese legislation as with regard to HR.

oca-clabot commented 9 years ago

Hey @andreparames, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla Here is a list of the users:

Appreciation of efforts, OCA CLAbot

andreparames commented 9 years ago

Sorry for the clabot above, we hadn't linked the git author to the Github user yet, so it didn't detected that we had signed the CLA.

dreispt commented 9 years ago

Welcome to OCA and thank you for publishing this!

Please note that it's normal to have some "pains" to adjust to the sctrict OCA code quality rules. But in the end it will pay of, and will get easier as we get used to them.

TravisCI is complaining about PEP8. Some work needed there. You might want to consider the autopep8 tool, and also this helper script.

max3903 commented 9 years ago

CLA problem should be fixed.

andreparames commented 9 years ago

Hi @dreispt, thanks a lot for the in-depth review, we'll get on to fixing these issues and will resubmit once they are fixed.

Thanks to you too, @max3903.

andreparames commented 9 years ago

Sorry, is the runbot working correctly? I seem to be unable to open its logs, and it says the runtime is 0s, which seems low :)

dreispt commented 9 years ago

At least until recently, OCA Runbot was not perfect. So don't worry too much about it for now.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 4a7fbb8e3c1aef24a15c81e3b994a7d1c3582e79 on ThinkOpen-Solutions:8.0 into \ on OCA:8.0**.

dreispt commented 8 years ago

@andreparames I'm helping to push this forward. is this the latest version or do you have any later work you can share?

pedrobaeza commented 6 years ago

Closing this as no further notices. It's a pity to not have more from Portuguese community, but we can't either accept modules that don't pass CIs.

andreparames commented 6 years ago

ping @hmrodrigues