search

OCA / l10n-portugal

Odoo Portuguese localization
GNU Affero General Public License v3.0
4 stars 26 forks source link

[ADD] l10n_pt_account for v9 #13

Closed thinkopen-pt closed 2 years ago

thinkopen-pt commented 8 years ago

After the submission of our previous version of this module, Odoo v9 has been released and so are re-submitting the module, while taking notice of the suggestions kindly offered by the reviewers of the other PR.

These commits also remove the LICENSE file from the base of the repository, as we believe each module should be allowed to have its own license.

dreispt commented 8 years ago

@andreparames Please make mr .Travis happy...

dreispt commented 8 years ago

@andreparames I believe that you have a later version of this code correct? is it for 9.0? If so, it's pointless to continue review this PR - can you create a new one with the latest code?

thinkopen-pt commented 8 years ago

The new changes have been submitted to this branch, along with a few cleanups.

dreispt commented 8 years ago

Hi, pylint-odoo found a list of good practices and style conventions to fix. Check https://travis-ci.org/OCA/l10n-portugal/jobs/160128728#L425

dreispt commented 8 years ago

The module fails to install. Can you check that? For details check https://travis-ci.org/OCA/l10n-portugal/jobs/160128729#L743

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 22.954% when pulling d241214fb840aba43aa8fad8216577787f73eca6 on ThinkOpen-Solutions:l10n_pt_account-90 into e4b05a2d972f843af6fdccce7c8c49f272f239cf on OCA:9.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 22.891% when pulling ea802cf956271e833f69b91555afe2b23dd8669a on ThinkOpen-Solutions:l10n_pt_account-90 into e4b05a2d972f843af6fdccce7c8c49f272f239cf on OCA:9.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 22.891% when pulling aaeb959af7b24816c3a7d0823532a3d03c5ce3b1 on ThinkOpen-Solutions:l10n_pt_account-90 into e4b05a2d972f843af6fdccce7c8c49f272f239cf on OCA:9.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 22.891% when pulling ff6fa550689de3f5ee2ab673e83e4df4421c8673 on ThinkOpen-Solutions:l10n_pt_account-90 into e4b05a2d972f843af6fdccce7c8c49f272f239cf on OCA:9.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 22.891% when pulling ff6fa550689de3f5ee2ab673e83e4df4421c8673 on ThinkOpen-Solutions:l10n_pt_account-90 into e4b05a2d972f843af6fdccce7c8c49f272f239cf on OCA:9.0.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 22.954% when pulling 945ba8278af77ae9ad07e47b0621d290a697ca7d on ThinkOpen-Solutions:l10n_pt_account-90 into e4b05a2d972f843af6fdccce7c8c49f272f239cf on OCA:9.0.

andreparames commented 7 years ago

@dreispt sorry, Travis seems to be complaining that an object lacks access rules, but it's an inherited object, so the access rules are already defined in the parent module. Is this a bug in the check, or am I missing something? Thanks.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 27.887% when pulling 668b0cc8a9e9cf1b28292327f9d6e2db6d52aad0 on ThinkOpen-Solutions:l10n_pt_account-90 into e4b05a2d972f843af6fdccce7c8c49f272f239cf on OCA:9.0.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 27.887% when pulling 814d393f8dd07abbb7be9d09959e9a2b5bba103b on ThinkOpen-Solutions:l10n_pt_account-90 into e4b05a2d972f843af6fdccce7c8c49f272f239cf on OCA:9.0.

dreispt commented 7 years ago

@andreparames Please also check the lint warnings on the TravisCI log. The tab-vs-spaces are not an issue, but using the old API unless really necessary is.

dreispt commented 7 years ago

Notice that the CI tests are failing. Lint logs: https://travis-ci.org/OCA/l10n-portugal/jobs/183559305#L300

dreispt commented 7 years ago

Travis is still red.

dreispt commented 7 years ago

Ping!

dreispt commented 7 years ago

Will you continue work on this?

github-actions[bot] commented 2 years ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.