OCA / l10n-switzerland

Odoo Swiss localization
GNU Affero General Public License v3.0
53 stars 163 forks source link

[11.0][FIX] l10n_ch_pain_base: incorrect compute_sepa_final_hook #487

Closed BT-tpiric closed 4 years ago

BT-tpiric commented 5 years ago

Removed incorrect compute_sepa_final_hook from AccountPaymentOrder. pain_flavor is the used xsd version for pain files, for example pain.001.001.03.ch.02. If the "ch" is in pain_flavor, it doesn't mean that the used payment type is "ISR".

The pain.001.001.03.ch.02 definition covers all current possible payment types in Switzerland (national, cross-border, SEPA, etc.), see https://www.six-group.com/interbank-clearing/dam/downloads/en/standardization/iso/swiss-recommendations/implementation-guidelines-ct.pdf, sites 18 to 21.

yvaucher commented 4 years ago

Use of ISR is defined by the use of local_instrument CH01 (Type 1)

The comment might be wrong but we still don't want to trigger the addition of SvcLvl/Cd/SEPA in our XML files unless we have a Type 5.

This must be used with Type 5 for other I don't think we want to add it. IIRC some bank refuse and other ignore SvcLvl for Type 1

Ref https://www.six-group.com/interbank-clearing/dam/downloads/en/standardization/iso/swiss-recommendations/implementation-guidelines-ct.pdf Pages 27 lines 2.8 and 2.9

EDIT: And the table at page 19 mention it must not be used for other types than Type 5

yvaucher commented 4 years ago

I'll close this in favor of https://github.com/OCA/l10n-switzerland/pull/487