search

OCA / management-system

Odoo for Management Systems (ISO, IEC, BS)
http://odoo-community.org/project/26
GNU Affero General Public License v3.0
193 stars 298 forks source link

[MIG][17.0] mgmtsystem_nonconformity #596

Closed EdgarRetes closed 1 month ago

max3903 commented 2 months ago

/ocabot migration mgmtsystem_nonconformity

bosd commented 2 months ago

Thanks for this migration. There are some warnings in the test log. Can you please attend to them?

peluko00 commented 1 month ago

Can you merge migration commits into one please @EdgarRetes

EdgarRetes commented 1 month ago

Can you merge migration commits into one please @EdgarRetes

Done!

EdgarRetes commented 1 month ago

Hi @EdgarRetes, I did a test on runboat and found some issues. In particular for me there are some errors in nonconformity view migration for example on the invisibility rule for Actions and Causes and Analysis, where attrs="{'invisible':[('state','in',['draft','cancel'])]}" is refactored as invisible="state not in 'draft' and state not in 'cancel'". I changed the code on the fly in runboat and it allows me to go further with state change (after filling the required fields). Please let me know if I'm wrong and if I can help in some way.

You are right, I had them wrong. Thanks for your comment! Let me know if you have some other erros

mymage commented 1 month ago

You are right, I had them wrong. Thanks for your comment! Let me know if you have some other erros

I don't know if it's my problem, but I don't see the runboat link to test it. Maybe you need to push again to update the generation? Thanks

EdgarRetes commented 1 month ago

You are right, I had them wrong. Thanks for your comment! Let me know if you have some other erros

I don't know if it's my problem, but I don't see the runboat link to test it. Maybe you need to push again to update the generation? Thanks

I just pushed it again

max3903 commented 1 month ago

/ocabot merge nobump

OCA-git-bot commented 1 month ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-596-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot commented 1 month ago

It looks like something changed on 17.0 in the meantime. Let me try again (no action is required from you). Prepared branch 17.0-ocabot-merge-pr-596-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at 5ad92f061b9a92f110a5618ae3f92a6c58e58e47. Thanks a lot for contributing to OCA. ❤️