[14.0][MIG]&[FIX] remove_odoo_enterprise

clementmbr commented 3 years ago

Third PR (based on #33) to migrate the module remove_odoo_enterprise but I hope this one is the right one :sparkles: cf #33 #38

Basically there were 2 mistakes made in v13 :

it's better to hide the field enterprise field rather than remove it because it can break some other part of the res.config.settings view (as it did for me when I installed hr_timesheet, which led me to make this PR)
it's important to hide the enterprise field's grandparent and not great-grandparent in v14 otherwise it will hide other non-enterprise fields :

(to be honest I didn't check how is build the res.config.settings.view before v14, it can be interesting to check if it was not a problem in v13 too...)

...and I added some tests for code coverage.

cc @rvalyi

rvalyi commented 3 years ago

just to make things clear when the fields were removed brutally in the former PRs, you would have errors such as Error: While parsing modifiers for div: for modifier "invisible": Unknown field module_project_timesheet_synchro in domain because of view domains refering to these fields as when @clementmbr installed hr_timesheet

rvalyi commented 3 years ago

/ocabot merge nobump

OCA-git-bot commented 3 years ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-39-by-rvalyi-bump-nobump, awaiting test results.

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at 00165844f36245d6033b0a8bd1578245e5fa945f. Thanks a lot for contributing to OCA. ❤️

OCA / server-brand

[14.0][MIG]&[FIX] remove_odoo_enterprise #39