search

OCA / server-ux

GNU Affero General Public License v3.0
163 stars 532 forks source link

[16.0][FIX] base_tier_validation: use record from props instead of env in tier_review widget #884

Closed AnizR closed 1 month ago

AnizR commented 6 months ago

Based on #793

I had an issue adding a Many2one of a model that uses tier validation (in my case: purchase.order) in the form view of an other model (in my case: maintenance.request).

The PR #793 was partially fixing my issue but I still had an issue in the tier_review widget: const records = this.env.model.root.data.review_ids.records; We are trying to take the model from the env but, this.env.model represents the other model (in my case: maintenance.request).

It is better to retrieve the data from the props instead

OCA-git-bot commented 6 months ago

Hi @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!

github-actions[bot] commented 2 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.