search

OCHA-DAP / ocha-anticipy

Python package to support the development of anticipatory action frameworks
https://github.com/OCHA-DAP/ocha-anticipy
GNU General Public License v3.0
8 stars 1 forks source link

Add easy HRP countries #188

Closed turnerm closed 1 year ago

turnerm commented 1 year ago

Here are the "easy" HRP countries (without strange COD AB issues mentioned here.

Opening as a draft because I still have to test everything myself!

caldwellst commented 1 year ago

Nice! Will review in a minute. Wondering, should we just address #184 already in this PR for these new countries + the few existing?

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@400dd87). Click here to learn what that means. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             develop     #188   +/-   ##
==========================================
  Coverage           ?   90.77%           
==========================================
  Files              ?       19           
  Lines              ?     1311           
  Branches           ?        0           
==========================================
  Hits               ?     1190           
  Misses             ?      121           
  Partials           ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

turnerm commented 1 year ago

Nice! Will review in a minute. Wondering, should we just address https://github.com/OCHA-DAP/ocha-anticipy/issues/184 already in this PR for these new countries + the few existing?

Good point, let me test if it actually makes a difference. But maybe better as its own PR not to make this one too big.

Wondering, is there any way we should be testing these to make sure they don't silently fail eventually?

Yes this will undoubtedly be an issue, the solution IMO would be some kind of E2E testing. But in the meantime we can just monitor the COD Skype group for any updates.