search

OCHA-DAP / pa-anticipatory-action

Code and documentation for analytical work on OCHA Anticipatory Action pilots.
GNU General Public License v3.0
14 stars 0 forks source link

Feature/ner food insecurity #282

Closed joseepoirier closed 2 years ago

joseepoirier commented 2 years ago

@Tinkaa I thought this branch had been merged but apparently not. Should we?

joseepoirier commented 2 years ago

I actually didn't go through with the analysis (it was out of curiosity), but the docs could be used to pull FS data in the future. If not worth it we can also just delete everything.

Tinkaa commented 2 years ago

Awesome you used the HDX R library!

We are not planning on doing any additional analysis on NER right?

Cause in that case I would tend towards deleting it 😢 Reasoning being that merging this will create the idea that we did analyses for NER while we didn't really. And in principle how to pull FS data will be saved by the legacy of this PR

(another option would be to use the same methodology for the bfa/tcd FS data but I get if you don't feel like investing in that)

Would you agree to not merge this branch?

joseepoirier commented 2 years ago

Yeah I thought we might go that route since the work wasn't fully executed or used. I'm okay with deleting the branch, I mainly wanted to clean it since it's been open for a while.

Tinkaa commented 2 years ago

Sounds good! I will delete the branch