search

OCamlPro / owi

WebAssembly Swissknife & cross-language bugfinder
https://ocamlpro.github.io/owi/
GNU Affero General Public License v3.0
137 stars 18 forks source link

fix many CI related issues #446

Closed zapashcanon closed 1 week ago

filipeom commented 2 weeks ago

I think because --with-test installs alt-ergo (because of frama-c) it will not compile smtml.0.3.1 since it needs a development version of alt-ergo.

Maybe we can add this pin in owi to fix the CI:

 ["alt-ergo-lib.2.6.0" "git+https://github.com/OCamlPro/alt-ergo.git#7ee96296a5de9588a4d585b3b8abec35f4755425"]
zapashcanon commented 2 weeks ago

Thanks. :) I'll try this but shouldn't our dependency on smtml.0.3.1 force opam to use the development version of alt-ergo ?

filipeom commented 2 weeks ago

Thanks. :) I'll try this but shouldn't our dependency on smtml.0.3.1 force opam to use the development version of alt-ergo ?

I had to remove the pinned dependencies from smtml's .opam file. I only noticed this when I made the last PR to update Owi. But I'll update smtml's .opam file in the opam repository once a new version of alt-ergo is released

zapashcanon commented 2 weeks ago

Ah yes sure, makes sense, they won't let you commit a pin-depends in opam-repo. I'll merge this as is for now. We can remove it later once new alter-ergo and smtml versions are released.

EDIT: actually it does not seem happy about this alt-ergo version

filipeom commented 2 weeks ago

It was missing the alt-ergo solver pin as well I believe

filipeom commented 2 weeks ago

I think we just have to promote now. The backtrace is annoying, we were having issues with Colibri2's dependencies turning on the backtrace. It seems that alt-ergo might do that as well? (ref. https://github.com/formalsec/smtml/issues/212#issuecomment-2365210635)

zapashcanon commented 2 weeks ago

Done. Let's see if it works now...

I opened an issue (#455) so we don't forget to investigate why the backtraces are turned on.

zapashcanon commented 1 week ago

OK, looks like we are hitting https://github.com/ocaml/setup-ocaml/issues/897 on macOS.

For the linux build, I'm not sure what's going on, there's no proper error displayed...

filipeom commented 1 week ago

For the linux build, I'm not sure what's going on, there's no proper error displayed...

Looks like we're running out of diskspace in the runner. You can see the errors at the top of the CI result

image

We should try and run this in debug mode and see if the submodules, or something is taking up a lot of disk space. I was having similiar issues with disk space running out due to opam checking out submodules when it detects a .gitmodules in the directory. I ended up doing this hack https://github.com/formalsec/smtml/pull/244

zapashcanon commented 1 week ago

Aww, thanks, I missed it somehow... Let's see now!

zapashcanon commented 1 week ago

Fix #411