search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Error in DataLoggerFiles and DataLoggerFileColumns #132 #133

Closed miguelcleon closed 6 years ago

miguelcleon commented 6 years ago

@lsetiawan I went ahead and made the fix for issue #132

see that the first one, this is caused by Dataloggerfiles model, mapping to the wrong column within the database: https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L458.

For the second one, measurementequation is indeed misspelled: https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L514.

miguelcleon commented 6 years ago

why did this fail @lsetiawan @ocefpaf ?

miguelcleon commented 6 years ago

also

found two more problems with dataloggerfiles model There is no column dataloggeroutputfiledescription instead it is dataloggerfiledescription https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L460

There is no column dataloggeroutputfilelink instead it is dataloggerfilelink https://github.com/ODM2/ODM2PythonAPI/blob/master/odm2api/ODM2/models.py#L461

miguelcleon commented 6 years ago

I can confirm instances of these models can now be retrieved without error.

lsetiawan commented 6 years ago

Sorry for replying to this so late. Was out sick yesterday. It seems like travis error is from Python 3.2 and 3.3 not being able to build the conda environment. Nothing to do with the changes. But, changes should go into the development branch rather than master. Please be advised. Thanks.

lsetiawan commented 6 years ago

Moved to #134. Closing.