search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Setup clean #46

Closed valentinedwv closed 8 years ago

valentinedwv commented 8 years ago

Adds travisCI tests, which runs postgres, mysql, and sqlite database tests. Setup can be used to publish to PiPy

emiliom commented 8 years ago

@valentinedwv, give us a day or so before trying to merge this into master. We have @sreeder's large changes waiting in the pipeline (I'm about to start reviewing them) first.

At the BiGCZ call tomorrow let's talk about your setup/PyPI work and my parallel, overlapping work setting up an anaconda channel with an odm2api package.

sreeder commented 8 years ago

@valentinedwv I am really looking forward to having the TravisCI tests. @emiliom my changes are requested to be merged with the development branch so they would not conflict with the work on the master yet.

valentinedwv commented 8 years ago

Only thing this hits is the ODMConnection.py and the tests folder. Failing tests are ODM11.

emiliom commented 8 years ago

Only thing this hits is the ODMConnection.py and the tests folder.

And requirements.txt, setup.py, etc. These may impact our parallel work on conda packaging.

How about splitting the PR to separate all the changes to the tests folder and ODMCOnnection.py, vs changes impacting setup? That way you can move forward with the former, and we can discuss the latter.

Thanks.

valentinedwv commented 8 years ago

moved to shell scripts

valentinedwv commented 8 years ago

Can we merge this?

emiliom commented 8 years ago

Great!