search

ODM2 / ODM2PythonAPI

A set of Python functions that provides data read/write access to an ODM2 database by leveraging SQLAlchemy.
http://odm2.github.io/ODM2PythonAPI/
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Odmtools #76

Closed sreeder closed 7 years ago

sreeder commented 7 years ago

These changes add functionality to the read services and create the basic, create, update and delete functions needed. it also cleans up and improves some of the connection stuff

emiliom commented 7 years ago

@sreeder, this is a lot of changes in one PR! I haven't had time to review them, and won't be able to this week. If you're in a hurry go ahead and merge. Otherwise I'll do at least a partial review early next week, then merge the PR.

emiliom commented 7 years ago

@sreeder, I don't think there's any way I can catch up with trying to review so many changes! If you're actively using this new version of odm2api (via ODM tools, as it sounds like you are?), I assume you've tested it well and you're confident about what's in it. I suggest you go ahead and merge, but please make a brief list of the important changes. Seeing the labels for each commit alone can be confusing b/c one commit may tweak what a previous commit did.

Having a few more details than your PR text ("These changes add functionality to the read services and create the basic, create, update and delete functions needed. it also cleans up and improves some of the connection stuff") will be helpful, for future reference. eg, what can kind of functionality was added to read services, and what improvements were made to the connection stuff (briefly)?

Thanks!

cc @horsburgh