search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Fix dataType and add generalCategory #153

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

This addresses dataType and generalCategory for #152.

emiliom commented 7 years ago

@lsetiawan, thanks. Give me a chance to review this first, and also to comment on issue #152. But, not till Monday, unfortunately ...

lsetiawan commented 7 years ago

@emiliom Sounds good. I'll leave this here until your approval. Thanks.

emiliom commented 7 years ago

@lsetiawan, I think it'd be helpful to be able to run specific tests on this, before merging into master. Would it add much complexity to create a branch instead of PR to master, and then install that branch locally to run against a known test DB (eg, SQLite, or our AWS-based MySQL and PostgreSQL databases)? I've been browsing the wofpy code per your pointers, to start wrapping my head around this.

lsetiawan commented 7 years ago

@emiliom I have tested these changes against the AWS-based MySQL that we have.

emiliom commented 7 years ago

I'll merge this (it really is an improvement!), and follow up on my comments in #152 about more comprehensive, more 1.1 compliant mappings for these two CV's.