search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Fix unicode error #155

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

This PR addresses #148, At least for the Envirodiy database https://github.com/ODM2/WOFpy/issues/148#issuecomment-312350361.

Reference: https://docs.python.org/2/library/stringio.html#module-cStringIO

cc. @miguelcleon

emiliom commented 7 years ago

Thanks! FYI: I probably won't review this until early next week! Ping me mid Monday if I haven't followed up.

lsetiawan commented 7 years ago

After further testing, this solution doesn't seem to work that well, and it is not robust enough. Closing this PR.

ocefpaf commented 7 years ago

@lsetiawan I have some experience with this (but the ascii-unicode-bytes is always a little bit painful.)

If you can create a few tests that shows the error I can send a PR once I get back from SciPy.