search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Cv handling #159

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

This PR addresses #152. Mapping between ODM2 CV and WaterML 1.1 CV needs to be done. This basically moves all the checks functions from core_1_1.py to utils.py. Also adds some automation in retrieving the most update WaterML 1.1 CV in the Master Registry.

emiliom commented 7 years ago

Thanks, @lsetiawan! These are great steps in the right direction. I really like the caching of the latest, relevant ODM/WaterML 1.1 at the time the wofpy server is started.

What your PR doesn't address yet is the need to "curate" a mapping between ODM 2 and ODM 1.1 vocabulary terms in a way that's not just 1:1. I'm not sure how we reconcile your dynamic, automatic approach (ie, just pull in the latest vocabularies) with the need to develop mappings that are manually maintained.

Also, personally I think I would put all this vocabulary related code in a more focused module (eg, "vocabularies.py") rather than the new generic "util.py" you've created.

BUT, your PR is great progress, so I'm merging so I don't slow you down. We can address my comments later.