search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Expose agency #164

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

This PR addresses #162. agencyName and agencyCode should show up when organizationtype matches either Government agency or Research agency.

emiliom commented 7 years ago

Thanks!! Awesome. See my comments and let me know what you think, before we merge this PR.

Did you test this along the lines of what we discussed today?

Also, for clarity, this PR is not only enhancing the core/common wofpy code to fully support agency attributes; it's also specifically implementing it in the ODM2 timeseries DAO only. Nothing wrong with that. Just making this scope explicit here.

emiliom commented 7 years ago

Also, I just noticed that Travis-CI failed but AppVeyor succeeded?! Do you know why?

lsetiawan commented 7 years ago

Did you test this along the lines of what we discussed today?

Yepp all is tested.

Also, I just noticed that Travis-CI failed but AppVeyor succeeded?! Do you know why?

Weird.. Travis says this is because there's no Affiliation:

AttributeError: 'NoneType' object has no attribute 'OrganizationObj' I'll get error catching soon.

This PR is not ready to merge until further notice and fixes.

emiliom commented 7 years ago

Yepp all is tested.

Great.

This PR is not ready to merge until further notice and fixes.

Ok

lsetiawan commented 7 years ago

@emiliom Please review further my latest changes and merge when you think they're good. Thanks.

emiliom commented 7 years ago

Looks good. Merging now.