Fixed Series/Site CV assignments for ODM2 timeseries DAO

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.

http://odm2.github.io/WOFpy/

9 stars 9 forks source link

Fixed Series/Site CV assignments for ODM2 timeseries DAO #182

Closed emiliom closed 7 years ago

emiliom commented 7 years ago

Addresses CV handling problem described in https://github.com/ODM2/WOFpy/issues/160#issuecomment-326148477, where not all CV's in GetSite* responses were still not being populated, for the ODM2 timeseries DAO. Specifically, this:

GetSiteInfo responses have "Unknown" values for valueType, dataType and sampleMedium, in both databases/endpoints.

Untested! @lsetiawan, please test it first.

emiliom commented 7 years ago

Variable TimeUnits and TimeSupport are not populated, b/c they would involve querying TimeSeriesResultValues, which is not currently done in get_series_by_sitecode and get_series_by_sitecode_and_varcode

lsetiawan commented 7 years ago

Variable TimeUnits and TimeSupport are not populated, b/c they would involve querying TimeSeriesResultValues, which is not currently done in get_series_by_sitecode and get_series_by_sitecode_and_varcode

Are we trying to address this before the release?

emiliom commented 7 years ago

Thanks!!

Variable TimeUnits and TimeSupport are not populated, b/c they would involve querying TimeSeriesResultValues, which is not currently done in get_series_by_sitecode and get_series_by_sitecode_and_varcode

Are we trying to address this before the release?

I guess not. It would involve modifying the queries, and making them a bit slower. Probably not worth it right now, w/o more discussion.

You haven't pushed this to the dev server/port, right? Could you do that now or first thing tomorrow morning? Thanks for merging the PR now.

lsetiawan commented 7 years ago

You haven't pushed this to the dev server/port, right? Could you do that now or first thing tomorrow morning? Thanks for merging the PR now.

It's up there about 2 seconds ago.

emiliom commented 7 years ago

I see it now. Awesome, thank you!!!

I'll do a bit more checking, but if I don't find new problems we're ready for the release and I'll issue it tonight or early tomorrow morning :grinning:

lsetiawan commented 7 years ago

I'll do a bit more checking, but if I don't find new problems we're ready for the release and I'll issue it tonight.

Great! I'm going to bed now. Don't wanna get in trouble with the fiancé 😜 haha.

emiliom commented 7 years ago

Thank you!