search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Add more robust unicode handling #187

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

Overview

This PR addresses https://github.com/ODM2/WOFpy/issues/148#issuecomment-326420842 issue regarding encoding. It seems that I missed some utf-8 encodings in WaterML_1_1.py and quote_xml is now made to use unicode codec to encode the characters coming in, which then will be encoded again to utf-8 so that it can be shown to the screen.

emiliom commented 7 years ago

@ocefpaf, I added you as the reviewer instead of me, since you're the unicode pro here, as demonstrated by your comment earlier today :wink:

Thanks, guys!

lsetiawan commented 7 years ago

Gah! @ocefpaf please help. What am i doing wrong.. it works in my computer... :(

emiliom commented 7 years ago

I'm glad I passed the buck to @ocefpaf -- even before the tests failed :innocent:

ocefpaf commented 7 years ago

I'll take a look in a few hours. (Trying to wrap the choropleth stuff in folium so we can ship it.)

emiliom commented 7 years ago

I'll take a look in a few hours.

No rush. The release is now out :) It can wait till early next week or so, if that helps you with getting Folium out.

(Trying to wrap the choropleth stuff in folium so we can ship it.)

Good luck!! Looking forward to it.

ocefpaf commented 7 years ago

@ocefpaf: seriously, there's no rush on this!! Go back to folium to finish it off and ship the release! Unless you enjoy distractions :stuck_out_tongue_winking_eye:

Too late. I won't be able to sleep if I don't fix this :smile: (or at least find a strategy for a long term plan.)

emiliom commented 7 years ago

Too late. I won't be able to sleep if I don't fix this :smile: (or at least find a strategy for a long term plan.)

Ok. I can't help you, then. But maybe I can look up online a good therapist to recommend, in your town ..

lsetiawan commented 7 years ago

@ocefpaf is handling this in #188. Closing...