search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

serviceWsdl attribute value not using actual domain name #191

Open emiliom opened 7 years ago

emiliom commented 7 years ago

In GetSiteInfo responses, the seriesCatalog element includes an attribute called serviceWsdl. Currently the value of the attribute uses the localhost domain:port, http://127.0.0.1:8080, rather than the actual domain name (and port) for the wofpy instance. I'm not certain (we'd need to look at WOF/WaterML specs and non-wofpy live WOF instances), but it'd make more sense if this url was the actual WSDL url, not a useless url.

Example from our live demo: Request: http://54.186.36.247:8080/mysqlodm2timeseries/rest/1_1/GetSiteInfo?site=mysqlodm2timeseries:USU-LBR-Mendon

Code chunk: 

<seriesCatalog menuGroupName="ODM2" serviceWsdl="http://127.0.0.1:8080/soap/wateroneflow_1_1.wsdl">
lsetiawan commented 7 years ago

I've changed the config to use the actual service wsdl that works. Thanks.

emiliom commented 7 years ago

I've changed the config to use the actual service wsdl that works.

Cool, thanks! I didn't realize this was hardwired in the config file. Are you saying you updated the config file(s) that's deployed on our AWS, or the ones on the wofpy repo? Is your change a generic one that will ensure this problem doesn't come up again for anyone -- namely, the appropriate domain is used for test vs production environments?

FYI, this isn't a high-priority issue.

lsetiawan commented 7 years ago

Are you saying you updated the config file(s) that's deployed on our AWS, or the ones on the wofpy repo?

AWS.

Is your change a generic one that will ensure this problem doesn't come up again for anyone -- namely, the appropriate domain is used for test vs production environments?

This change should be noted in the the documentation, because it is hardwired in config file. I can try to figure out a way to automate it, if that's better in the long run.

emiliom commented 7 years ago

This change should be noted in the the documentation, because it is hardwired in config file.

Thanks for the clarification.

I can try to figure out a way to automate it, if that's better in the long run.

Exactly. Again, low priority, but if you think it's easy, go right ahead.