search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

Fix missing unitCode element #207

Closed lsetiawan closed 7 years ago

lsetiawan commented 7 years ago

Overview

This PR should address #202. I have found three places within the code where unitCode is missing. This element is required based on the WaterML 1.1 schema.

emiliom commented 7 years ago

Looks good! I'm ready to merge, but have you run actual tests and do you have sample XML output for GetVariableInfo and GetValues, that we can look at (ie, validate)?

lsetiawan commented 7 years ago

@emiliom I just sent you some sample xmls through email. Thanks.