search

ODM2 / WOFpy

A server-side implementation of CUAHSI's Water One Flow service stack in Python.
http://odm2.github.io/WOFpy/
9 stars 9 forks source link

add docs section #235

Closed ocefpaf closed 5 years ago

ocefpaf commented 5 years ago

Forgot this part in #234

ocefpaf commented 5 years ago

I guess it looks ok ... Since I'm not in a position to know better.

This is the Travis-CI matrix item that we should watch for this PR:

https://travis-ci.org/ODM2/WOFpy/jobs/484509296

If that one passes we are OK.

emiliom commented 5 years ago

Thanks for the detailed explanations.

ocefpaf commented 5 years ago

Travis-CI is not starting :-/ Not sure what is going on, service outage or something wrong with the config file. I guess it is the former b/c we should see an error with the latter.

@emiliom while writing this I realize it is pointless to keep the coding standard and Python 3 boilerplate configurations. Are you OK removing them and keeping a simpler .travis.yaml file?

The rational is that fixing the coding standards is something that should be done with tools like black or no one will be willing to send the commits necessary to comply. Regarding Python 3 it is easy to enable when the code is ready for it.

ocefpaf commented 5 years ago

Oops, you were to fast! See my comment about Travis-CI not starting.

emiliom commented 5 years ago

Oops, you were to fast! See my comment about Travis-CI not starting.

Sorry ...

@emiliom while writing this I realize it is pointless to keep the coding standard and Python 3 boilerplate configurations. Are you OK removing them and keeping a simpler .travis.yaml file?

The rational is that fixing the coding standards is something that should be done with tools like black or no one will be willing to send the commits necessary to comply. Regarding Python 3 it is easy to enable when the code is ready for it.

Sure. Sounds good.