Implement convention model builder support for NonNullable Reference …

OData / ModelBuilder

A project to generate Edm (Entity Data Model) from CLR types

19 stars 19 forks source link

Implement convention model builder support for NonNullable Reference … #17

Closed dxrdxr closed 3 years ago

dxrdxr commented 3 years ago

Implement convention model builder support for NonNullable Reference Types

Issues

This pull request fixes issues #16, #15.

Description

Implements NonNullable Reference Types in the convention builder as described in detail of issue #16.

Checklist (Uncheck if it is not completed)

[x] Test cases added
[x] Build and test with one-click build and test script passed

Additional work necessary

Documentation needed similar to what exists in EF Core.

ghost commented 3 years ago

All CLA requirements met.

dxrdxr commented 3 years ago

Can anyone explain why TestPublicApi is failing on the Rolling build?

I cannot reproduce it locally in either Debug or Release. My changes do not appear to change the PublicApi.bsl.

I added context to the Assert and see that it is failing in the class StructuralTypeConfiguration but these changes do not touch that class (or base classes).

xuzhg commented 3 years ago

Thanks for your contribution. Let me know if you need a nuget package release. Otherwise, please use the nightly for testing.