search

OFS / opae-sdk

Open Programmable Acceleration Engine
https://ofs.github.io
BSD 3-Clause "New" or "Revised" License
251 stars 84 forks source link

opae.io: Fix error handling when binding the vfio-pci driver fails #3095

Closed anandaravuri closed 7 months ago

anandaravuri commented 7 months ago

The 'opae.io init' command can fail to bind the vfio-pci driver when the IOMMU is disabled, leaving the system seemingly unable to bind another driver. The fix is to check if the IOMMU is enabled before even attempting to bind the vfio-pci driver.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 7818328836

Totals Coverage Status
Change from base Build 7788148637: 0.0%
Covered Lines: 15809
Relevant Lines: 24507
💛 - Coveralls
fpgamatt commented 7 months ago

Can we improve the commit message to something like the following?

opae.io: Fix error handling when binding the vfio-pci driver fails

The 'opae.io init' command can fail to bind the vfio-pci driver when the IOMMU is disabled, leaving the system seemingly unable to bind another driver. The fix is to check if the IOMMU is enabled before even attempting to bind the vfio-pci driver.