OFS / opae-sdk

Open Programmable Acceleration Engine
https://ofs.github.io
BSD 3-Clause "New" or "Revised" License
251 stars 84 forks source link

hssi: set sbd properties to enumerate fpga device and set sbdf prope… #3103

Closed anandaravuri closed 6 months ago

anandaravuri commented 6 months ago

…rties to enumerate afu

Set PCIe segment, bus, and device properties to enumerate FPGA DEVICE (FME) Set PCIe segment, bus, device, and function properties to enumerate FPGA ACCELERATOR

hssi hssi_10g works fine, hssi—pci-address b1:00.6 hssi_10g fails if the user provides pci-address cmd args due to PR change. https://github.com/OFS/opae-sdk/pull/3094

Set the HSSI/VF PCIe segment, bus, device, and function attributes to try to enumerate FPGA DEVICE (FME) triggers failure, to enumerate FPGA DEVICE set seegment, bus, device attributes to OPAE filter.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 7919669269

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/afu-test/afu_test.h 1 3 33.33%
<!-- Total: 1 3 33.33% -->
Totals Coverage Status
Change from base Build 7880120507: -0.006%
Covered Lines: 15809
Relevant Lines: 24450

💛 - Coveralls
anandaravuri commented 6 months ago

Thanks @anandaravuri! Could you explain in the commit message why this change is needed, i.e., what was broken before and how does reparsing the PCIe address resolve the issue?

hssi hssi_10g works fine, hssi—pci-address b1:00.6 hssi_10g fails if the user provides pci-address cmd args due to PR change. https://github.com/OFS/opae-sdk/pull/3094

Set the HSSI/VF PCIe segment, bus, device, and function attributes to try to enumerate FPGA DEVICE (FME) triggers failure, to enumerate FPGA DEVICE set seegment, bus, device attributes to OPAE filter.

pcolberg commented 6 months ago

Thanks @anandaravuri, could you update the PR description accordingly?