search

OGCMetOceanDWG / WorldWeatherSymbols

A complete set of WMO weather symbols in SVG with full metadata.
https://github.com/OGCMetOceanDWG/WorldWeatherSymbols
Other
84 stars 34 forks source link

update SVGs with implicit XML namespacing #49

Open tomkralidis opened 3 months ago

tomkralidis commented 3 months ago

Fixes #47

tomkralidis commented 3 months ago

cc @aamnah

Note: while the SVGs do not render in the diff mode of this PR (i.e. https://github.com/OGCMetOceanDWG/WorldWeatherSymbols/pull/49/files), they do in branch view (i.e. https://github.com/OGCMetOceanDWG/WorldWeatherSymbols/tree/issue-47)

chris-little commented 3 months ago

@tomkralidis When reviewing this PR, I only see Unable to render rich display. Invalid iamge source, for every single file. Also, if I go to the code, similar error message. e.g. https://github.com/OGCMetOceanDWG/WorldWeatherSymbols/blob/master/symbols/CH_CloudHigh/WeatherSymbol_WMO_CloudHigh_CH_1.svg But I see the SVGs rendered in my fork in the code view. E.g. https://github.com/chris-little/WorldWeatherSymbols/blob/master/CH_CloudHigh/WeatherSymbol_WMO_CloudHigh_CH_1.svg or via the Issue-47 https://github.com/OGCMetOceanDWG/WorldWeatherSymbols/blob/issue-47/symbols/CH_CloudHigh/WeatherSymbol_WMO_CloudHigh_CH_1.svg