search

OH-SHOWN / ohshown-backend

OH!SHOWN 野生動物出沒痕跡通報系統
http://ohshown.site
MIT License
2 stars 8 forks source link

build(django-migration): ready to seed ohshown-event #58

Closed tai271828 closed 2 years ago

tai271828 commented 2 years ago

We have rename the factory model to ohshown_event model. However, the corresponding seed data (for testing) do not change accordingly. This commit gets the model ready to seed the data with seed-data-ohshown-event.csv.

Issue: #36

tai271828 commented 2 years ago

Hmmm CI failed (for expected failures). I will fix them. Convert the pull request to a draft.

tai271828 commented 2 years ago

off-topic: django 2.2 (which we are currently using) does not support DJANGO_SUPERUSER_USERNAME and DJANGO_SUPERUSER_PASSWORD when creating superuser for testing by manage.py createsuperuser. This make it a bit inconvenient to rebuild docker (for testing this pull request) repeatedly : (

tai271828 commented 2 years ago

Ok I fixed all test cases. Ready to review : D

tai271828 commented 2 years ago

Branch conflicts. Let me roll back. Sorry!

tai271828 commented 2 years ago

Ok now I understand. This pull request is a bit oudated for landing the other pull request, and I continue this pull request for implementing pull request #59. I resolved the conflict and create another pull request (pull request #59) for readability. I will deprecated this pull request (but keep my comments above), and please go to pull request #59 for reviewing. Thank you very much!